-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including protologbeat in list of community beats #4348
Including protologbeat in list of community beats #4348
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
@andrewkroh @tsg @ruflin I've added this latest beat i've created. As a sample use case, I'll be using it for diskless logging for application containers within a Kubernetes pod. I appreciate any feedback you guys might have. |
libbeat/docs/communitybeats.asciidoc
Outdated
@@ -61,6 +61,7 @@ https://github.com/kozlice/phpfpmbeat[phpfpmbeat]:: Reads status from PHP-FPM. | |||
https://github.com/joshuar/pingbeat[pingbeat]:: Sends ICMP pings to a list | |||
of targets and stores the round trip time (RTT) in Elasticsearch. | |||
https://github.com/carlpett/prombeat[prombeat]:: Indexes https://prometheus.io[Prometheus] metrics. | |||
https://github.com/hartfordfive/[protologbeat][protologbeat]:: Successor to udplogbeat. Accpets structure and unstructured logs via UDP or TCP. Can also be used to receive syslog messages or GELF formated messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the first [ ] brackets are too much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, missed that one. I'll fix that.
Very interesting. In the meantime I did quite a bit of refactoring of the filebeat prospector structure which now makes adding new prospector types easier and thing like this possible: #4180 It could be discussed if this should also be a prospector type? Or if it fits in filebeat or not? |
Yes I'm definitely open for that discussion. If you see it as beneficial to merge some of this functionality into the beats library, I'm all for it. Considering syslog messages have a predefined format, maybe that would be a good first candidate to integrate as a new prospector? I also like the idea of adding GELF as a potential prospector considering it does have a message standard although it can have some additional field names. Considering I've only briefly looked through the code in #4180, would you see the potential of unknown fields as a problem? Could this be something the user specifies in the YAML config? Also, keep in mind that the logs for this beat are all accepted via TCP or UDP instead of files like filebeat does. Could prospectors also be applied to non-file originating events? |
@ruflin On a total separate note (just as a heads up), I plan on also developing a custom beat to process logs from Sendgrid Webhook events. I may have some questions for you guys regarding that in the IRC chat sometime in the near future. |
@ruflin By the way, I was thinking about a few things regarding filebeat/libbeat. These ideas of mine might be totally off or unreasonable so don't hesitate to let me know if out of line! Considering now that filebeat has an Again, I know I might be way off on this, but I was just curious to know what you and the other team members feedback was on this? |
libbeat/docs/communitybeats.asciidoc
Outdated
@@ -61,6 +61,7 @@ https://github.com/kozlice/phpfpmbeat[phpfpmbeat]:: Reads status from PHP-FPM. | |||
https://github.com/joshuar/pingbeat[pingbeat]:: Sends ICMP pings to a list | |||
of targets and stores the round trip time (RTT) in Elasticsearch. | |||
https://github.com/carlpett/prombeat[prombeat]:: Indexes https://prometheus.io[Prometheus] metrics. | |||
https://github.com/hartfordfive/protologbeat[protologbeat]:: Successor to udplogbeat. Accpets structure and unstructured logs via UDP or TCP. Can also be used to receive syslog messages or GELF formated messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Accpets/Accepts/
I would put the successor part at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, seems like spelling skills are lacking today...
Perhaps it makes sense to have in the future a zoom conversation to discuss these points more directly as you seem to be working on quite a few things related to beats 🎉 |
Yes, we can definitely do a Zoom call sometime soon to go over those discussion points in more detail. |
No description provided.