Fixing configuration documentation for kubernetes processor #4313
Conversation
vjsamuel
force-pushed
the
avoid_duplicate_pod_updates
branch
from
8318397 to
6362558
Compare
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
|
@exekias, im still on the fence with this change. this would make sure that we always start at the most recent resource version. but this would also mean that we always miss events that were written by the API server when the watch was broken at our end. |
vjsamuel
changed the title
vjsamuel
force-pushed
the
avoid_duplicate_pod_updates
branch
from
6362558 to
8f39c8f
Compare
vjsamuel
changed the title
|
@exekias Updated the PR to just fix an issue in the configuration documentation. I dont think its a good idea to do the check based on last resource version. would result in losing metadata update events. |
|
@vjsamuel podwatcher stores last seen resource version, you could use that :) https://github.com/elastic/beats/blob/master/libbeat/processors/kubernetes/podwatcher.go#L22 |
CHANGELOG.asciidoc
Outdated
| @@ -215,6 +215,7 @@ https://github.com/elastic/beats/compare/v5.3.2...v5.4.0[View commits] | |||
| - Fix potential Elasticsearch output URL parsing error if protocol scheme is missing. {pull}3671[3671] | |||
| - Downgrade Elasticsearch per batch item failure log to debug level. {issue}3953[3953] | |||
| - Make `@timestamp` accessible from format strings. {pull}3721[3721] | |||
| - Fixing configuration documentation for kubernetes processor {pull}4313[4313] | |||
There was a problem hiding this comment.
Sorry, I just noticed this line went to an already released version, could you move it to the HEAD? also it would be great if you rename Fixing -> Fix
vjsamuel
force-pushed
the
avoid_duplicate_pod_updates
branch
2 times, most recently
from
fca62c9 to
02913cf
Compare
vjsamuel
force-pushed
the
avoid_duplicate_pod_updates
branch
from
02913cf to
32fe106
Compare
Fixing configuration documentation for kubernetes processor