Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41895) Fix log file rotation bug #41933

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 6, 2024

Proposed commit message

Fix a bug where log files are rotated on startup when interval is configured 
and rotateonstartup is disabled.

Closes: #41894

Relates: elastic/elastic-agent-libs#259

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

References

@mergify mergify bot requested a review from a team as a code owner December 6, 2024 14:42
@mergify mergify bot added the backport label Dec 6, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2024
@nicholasberlin nicholasberlin added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Dec 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2024
Copy link
Contributor Author

mergify bot commented Dec 9, 2024

This pull request has not been merged yet. Could you please review and merge it @nicholasberlin? 🙏

Fix a bug where log files are rotated on startup when interval is configured
and rotateonstartup is disabled.

Closes: #41894

Relates: elastic/elastic-agent-libs#259
(cherry picked from commit b1cc7c5)
@nicholasberlin nicholasberlin force-pushed the mergify/bp/8.x/pr-41895 branch from 4536715 to d3db476 Compare December 9, 2024 14:51
@nicholasberlin nicholasberlin enabled auto-merge (squash) December 9, 2024 14:52
@nicholasberlin nicholasberlin merged commit 5695d64 into 8.x Dec 9, 2024
142 checks passed
@nicholasberlin nicholasberlin deleted the mergify/bp/8.x/pr-41895 branch December 9, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Security-Linux Platform Linux Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants