Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input-kafka.asciidoc to indicate required version for Kafka 4.0 #41540

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

strawgate
Copy link
Contributor

Proposed commit message

Update input-kafka.asciidoc to indicate required version for Kafka 4.0

Related issues

#41473

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 6, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert
Copy link
Collaborator

Are we still targeting 9.0 for that?
If this is still the case, we should backport this to 8.x

@strawgate
Copy link
Contributor Author

Are we still targeting 9.0 for that?
If this is still the case, we should backport this to 8.x

This should be backport to 8.x for sure as its just a docs change and will work with 8.x, I think the updates to the Samara library and changing the default value for this are both candidates for work to be included in 9.x

@strawgate strawgate enabled auto-merge (squash) November 18, 2024 22:09
@strawgate strawgate disabled auto-merge November 18, 2024 22:12
@strawgate strawgate enabled auto-merge (squash) November 18, 2024 22:12
@strawgate strawgate merged commit df97534 into main Nov 18, 2024
142 checks passed
@strawgate strawgate deleted the strawgate-patch-kafka-instructions branch November 18, 2024 23:45
mergify bot pushed a commit that referenced this pull request Nov 18, 2024
#41540)

Update input-kafka.asciidoc to indicate required version for Kafka 4.0

(cherry picked from commit df97534)
strawgate pushed a commit that referenced this pull request Nov 22, 2024
#41540) (#41674)

Update input-kafka.asciidoc to indicate required version for Kafka 4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants