Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/metricbeat/module/mssql: Update mssql image version to avoid SIGABRT and update HEALTHCHECK #41104

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Oct 3, 2024

Proposed commit message

Related: microsoft/mssql-docker#868, microsoft/mssql-docker#881, sqldef/sqldef#560 (comment) (etc.)

Reported first here: #40924 (comment)

For 6.7 Linux Kernel, the 2017, 2019, and 2022 mssql versions started breaking. Microsoft has updated some images and now they are working. Please take a look at the linked issues for more info.

Not adding a CHANGELOG entry as it's a change that only impacts integration tests.

There's one more change that is required to fix another issue: elastic/integrations#10899; I fixed the same issue in integrations a couple of months back. Done the same here.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@shmsr shmsr added the bugfix label Oct 3, 2024
@shmsr shmsr requested a review from a team as a code owner October 3, 2024 19:28
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 3, 2024
@botelastic
Copy link

botelastic bot commented Oct 3, 2024

This pull request doesn't have a Team:<team> label.

@shmsr shmsr self-assigned this Oct 3, 2024
Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @shmsr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 3, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
@shmsr
Copy link
Member Author

shmsr commented Oct 3, 2024

There's one more change that is required to fix another issue: elastic/integrations#10899; I fixed the same issue in integrations couple of months back.

So I've updated the HEALTHCHECK.

@shmsr shmsr changed the title x-pack/metricbeat/module/mssql: Update mssql image version to avoid SIGABRT x-pack/metricbeat/module/mssql: Update mssql image version to avoid SIGABRT and update HEALTHCHECK Oct 3, 2024
@shmsr shmsr enabled auto-merge (squash) October 4, 2024 06:03
@shmsr shmsr merged commit 43301bc into elastic:main Oct 4, 2024
21 checks passed
mergify bot pushed a commit that referenced this pull request Oct 4, 2024
…IGABRT and update HEALTHCHECK (#41104)

(cherry picked from commit 43301bc)
shmsr added a commit that referenced this pull request Oct 7, 2024
…IGABRT and update HEALTHCHECK (#41104) (#41113)

(cherry picked from commit 43301bc)

Co-authored-by: subham sarkar <[email protected]>
@cmacknz cmacknz added backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify labels Oct 7, 2024
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
…IGABRT and update HEALTHCHECK (#41104)

(cherry picked from commit 43301bc)
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
…IGABRT and update HEALTHCHECK (#41104)

(cherry picked from commit 43301bc)
cmacknz pushed a commit that referenced this pull request Oct 7, 2024
…IGABRT and update HEALTHCHECK (#41104) (#41158)

(cherry picked from commit 43301bc)

Co-authored-by: subham sarkar <[email protected]>
cmacknz pushed a commit that referenced this pull request Oct 7, 2024
…IGABRT and update HEALTHCHECK (#41104) (#41159)

(cherry picked from commit 43301bc)

Co-authored-by: subham sarkar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify bugfix needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants