Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build tags in journald input #40666

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

belimawr
Copy link
Contributor

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

## Author's Checklist

How to test this PR locally

Build Filebeat by running: GOOS=linux GOARCH=arm64 go build

## Related issues
## Use cases
## Screenshots
## Logs

@belimawr belimawr added backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Aug 30, 2024
@belimawr belimawr requested a review from a team as a code owner August 30, 2024 17:20
@belimawr belimawr requested review from faec and VihasMakwana August 30, 2024 17:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 30, 2024
@belimawr belimawr enabled auto-merge (squash) August 30, 2024 19:47
@belimawr
Copy link
Contributor Author

Auto-merge is enabled

@mauri870
Copy link
Member

mauri870 commented Sep 2, 2024

@belimawr Out of curiosity, what is the reasoning behind requiring cgo to build this? Mind adding it to the MR description? Thanks.

@VihasMakwana
Copy link
Contributor

@belimawr Out of curiosity, what is the reasoning behind requiring cgo to build this? Mind adding it to the MR description? Thanks.

@mauri870 I think Tiago has removed the cgo dependency in this PR 😅

@mauri870
Copy link
Member

mauri870 commented Sep 2, 2024

@belimawr Out of curiosity, what is the reasoning behind requiring cgo to build this? Mind adding it to the MR description? Thanks.

@mauri870 I think Tiago has removed the cgo dependency in this PR 😅

Thanks for pointing that out! 😅 I was actually curious about the reasoning behind the removal of the cgo dependency. Was it added by mistake initially, or was there a specific reason for its removal?

@belimawr
Copy link
Contributor Author

belimawr commented Sep 3, 2024

@belimawr Out of curiosity, what is the reasoning behind requiring cgo to build this? Mind adding it to the MR description? Thanks.

@mauri870 I think Tiago has removed the cgo dependency in this PR 😅

Thanks for pointing that out! 😅 I was actually curious about the reasoning behind the removal of the cgo dependency. Was it added by mistake initially, or was there a specific reason for its removal?

Yes, I removed the CGO build tag, CGO I not required to build Filebeat any more.

Not long ago (before #40061 was merged) the journald input used github.com/coreos/go-systemd/v22/sdjournal that required CGO, hence Filebeat required CGO when build with the jouranld input (there were build tags to configure it, a simple go build . would not include the journald input).

Nowadays CGO is not needed any more, but some build tags were forgotten and that was not caught on CI. The AMD64 builds do not seem to be affected, only the ARM ones.

@belimawr belimawr merged commit 6715964 into elastic:main Sep 3, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants