-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build tags in journald input #40666
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Auto-merge is enabled |
@belimawr Out of curiosity, what is the reasoning behind requiring cgo to build this? Mind adding it to the MR description? Thanks. |
Thanks for pointing that out! 😅 I was actually curious about the reasoning behind the removal of the cgo dependency. Was it added by mistake initially, or was there a specific reason for its removal? |
Yes, I removed the CGO build tag, CGO I not required to build Filebeat any more. Not long ago (before #40061 was merged) the journald input used Nowadays CGO is not needed any more, but some build tags were forgotten and that was not caught on CI. The AMD64 builds do not seem to be affected, only the ARM ones. |
Proposed commit message
See title
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
None
## Author's ChecklistHow to test this PR locally
Build Filebeat by running:
GOOS=linux GOARCH=arm64 go build
## Related issues## Use cases## Screenshots## Logs