-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metricbeat: Update beat module with apm-server monitoring metrics fields #40127
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
@@ -35,6 +35,7 @@ var ( | |||
"cgroup": c.Ifc("beat.cgroup"), | |||
"system": c.Ifc("system"), | |||
"apm_server": c.Ifc("apm-server"), | |||
"output": c.Ifc("output"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[to reviewer] this is required for beat.stats.output.elasticsearch.*
5f7fc5e
to
8925c9f
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
8925c9f
to
d5c0736
Compare
d5c0736
to
249524c
Compare
@@ -33,7 +33,7 @@ import ( | |||
|
|||
func TestEventMapping(t *testing.T) { | |||
|
|||
files, err := filepath.Glob("./_meta/test/stats.*.json") | |||
files, err := filepath.Glob("./_meta/test/*.stats.*.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[to reviewer] it wasn't testing apm-server.stats.712.json, not sure if it was intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea but we'll know if CI fails :)
@@ -175,6 +175,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff] | |||
- Fix query logic for temp and non-temp tablespaces in Oracle module. {issue}38051[38051] {pull}39787[39787] | |||
- Set GCP metrics config period to the default (60s) when the value is below the minimum allowed period. {issue}30434[30434] {pull}40020[40020] | |||
- Fix missing metrics from CloudWatch when include_linked_accounts set to false. {issue}40071[40071] {pull}40135[40135] | |||
- Update beat module with apm-server monitoring metrics fields {pull}40127[40127] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[to reviewer] double checking: if we are looking to backport this PR to 8.15, is this still the right place for the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/beats would you know about that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…lds (#40127) (#40167) * Update metricbeat beat module mapping to contain latest apm-server monitoring metrics fields * Update schema to parse output fields from stats * Update tests (cherry picked from commit d79d852) Co-authored-by: Carson Ip <[email protected]>
Proposed commit message
output
fields from statsChecklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
metricbeat-*
data streamManual testing results described in elastic/apm-server#13475
Related issues
Use cases
Screenshots
Logs