-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubernetes - Metricbeat] Providing config option to disable Kubeadm config api requests #40086
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
I have updated description and autodiscovery library to make use of use_kubeadm variable See comment elastic/elastic-agent-autodiscover#98 (comment) |
…i requests (#98) Related changes needed for elastic/beats#40086
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
@MichaelKatsoulis I added again the use_kubeadm option here Reason is that kubelet metricsets, proxy and scheduler make use of AddClusterECSMeta (like here) which is using finally the kubernetes config struct. I have repeated the tests and now works ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elastic/beats-tech-leads can I have a review here? The pr looks good and tested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving go.mod changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
NOTE: Dont merge until elastic/elastic-agent-autodiscover#98 is also mergedThe elastic-agent-autodoscover library updated to v0.8.2
Proposed commit message
WHAT: Provide a configuration option to disable
/api/v1/namespaces/kube-system/configmaps/kubeadm-config
. In more details user will disable the api requests to the modules he configures by using configurationuse_kubeadm: false
WHY: https://github.com/elastic/enhancements/issues/21172
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
elastic-package stack up -d -v --version=8.15.0-SNAPSHOT
replace github.com/elastic/elastic-agent-autodiscover => /Users/andreasgkizas/elastic/elastic-agent-autodiscover
go mod tidy
use_kubeadm: false
flag in your enabled modulesRelated issues
Screenshots
With 8.15.0 Image no changes:
We enable all metricsets (included events) and we have 85 API requests
With This repo code but the flag is
disable_kubeadm: false
We enable all metricsets (included events) and we still have 85 API requests
With This repo code but the flag is disable_kubeadm: true`
We have no API requests after 10:04 that metrics collection established