Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on cgroupns usage for metricbeat under docker #39889

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

fearful-symmetry
Copy link
Contributor

Proposed commit message

This adds a section to the "running on docker" doc to mention the use of --cgroupns=host.

While monitoring for private cgroup namespaces technically works (after no small amount of effort), the basic use case of "monitor the host cgroups from within a container with a private cgroup namespace" requires a considerable amount of hacks and should probably be considered best-effort. This adds a section telling the user to select a host namespace.

@fearful-symmetry fearful-symmetry added the Team:Elastic-Agent Label for the Agent team label Jun 12, 2024
@fearful-symmetry fearful-symmetry self-assigned this Jun 12, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 12, 2024
Copy link
Contributor

mergify bot commented Jun 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 13, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pierrehilbert
Copy link
Collaborator

Adding @blakerouse & @michalpristas as reviewers for the docker knowledges.

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Completely makes sense that you would want the container to use the host namespace so the cgroup information is correct.

@fearful-symmetry fearful-symmetry merged commit 974ace6 into elastic:main Jun 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants