Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][filebeat]: add 4th step in migrate-to-filestream #39863

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

VihasMakwana
Copy link
Contributor

Proposed commit message

Follow up PR from #39828.

Add a 4th step to enure that the user disables take_over mode once they start receiving events with take_over tag.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@VihasMakwana VihasMakwana added docs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 12, 2024
@VihasMakwana VihasMakwana self-assigned this Jun 12, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 12, 2024
Copy link
Contributor

mergify bot commented Jun 12, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @VihasMakwana? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@VihasMakwana VihasMakwana force-pushed the docs-filebeat-takeover branch from c301eb1 to 708e1b2 Compare June 12, 2024 07:31
@pierrehilbert pierrehilbert requested review from kilfoyle and rdner June 12, 2024 07:32
@VihasMakwana VihasMakwana force-pushed the docs-filebeat-takeover branch from 708e1b2 to 94a2163 Compare June 12, 2024 07:36
@VihasMakwana VihasMakwana force-pushed the docs-filebeat-takeover branch from 94a2163 to c45190f Compare June 12, 2024 07:37
@pierrehilbert
Copy link
Collaborator

@VihasMakwana even if Julien & I approved the PR, please wait for @kilfoyle's review to ensure consistency between our docs.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Just one small suggestion.

@VihasMakwana VihasMakwana merged commit 09707a2 into elastic:main Jun 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants