[8.14](backport #39807) [Docker] Stop returning errors when there are no metric values #39829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Return nil instead or an error if no metrics The docker metricset returns an error when there are no memory metric values available. This condition can happen when there are no running containers on Docker. When no containers are running, the metricset returns an error at every collection, creating noise. * Add a "docker.memory" logger to write a debug message on no-metrics (cherry picked from commit 4c1d3f2)
mergify
bot
requested review from
AndersonQ and
faec
and removed request for
a team
botelastic
bot
added
the
needs_team
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
|
This pull request has not been merged yet. Could you please review and merge it @zmoog? 🙏 |
pierrehilbert
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Stop returning errors when there are no metric values for the Docker memory metricset.
The docker metricset returns an error when there are no memory metric values available. This condition can happen when there are no running containers on Docker.
When no containers are running, the metricset returns an error at every collection, creating noise.
Notes for reviewers
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
This is an automatic backport of pull request #39807 done by [Mergify](https://mergify.com).