-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines #39510
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
a3113bc
to
c63d291
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add those definitions in the deploy/k8s pipeline: https://github.com/elastic/beats/blob/main/.buildkite/deploy/kubernetes/deploy-k8s-pipeline.yml ?
There are no go tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ines (#39510) (#39519) * Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines * Moved DOCKER_PULL var to winlogonbeat pipeline * added xpack/heartbeat (cherry picked from commit c773028) Co-authored-by: Pavel Zorin <[email protected]>
…ines (#39510) (#39518) * Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines * Moved DOCKER_PULL var to winlogonbeat pipeline * added xpack/heartbeat (cherry picked from commit c773028) Co-authored-by: Pavel Zorin <[email protected]>
…ines (#39510) (#39520) * Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines * Moved DOCKER_PULL var to winlogonbeat pipeline * added xpack/heartbeat (cherry picked from commit c773028) Co-authored-by: Pavel Zorin <[email protected]>
…-actions * upstream/main: (313 commits) github-action: delete opentelemetry workflow (elastic#39559) updatecli: move to the .github folder and support for signed commits (elastic#39472) Osquerybeat: Add action responses data stream (elastic#39143) [winlogbeat] performance improvment; avoid rendering event message twice (elastic#39544) Fix the AWS SDK dependencies issue causing the "not found, ResolveEndpointV2" error (elastic#39454) x-pack/filebeat/input/cel: add http metrics collection (elastic#39503) build(deps): bump github.com/elastic/elastic-agent-libs from 0.9.4 to 0.9.7 (elastic#39424) Remove unused env vars from pipelines (elastic#39534) [BK] - Remove osx steps from branch execution (elastic#39552) [BK] - Remove certain steps from running for Branches (elastic#39533) Allow dependabot report BK status checks (elastic#39540) Remove hardcoded module definitions in CI (elastic#39506) Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines (elastic#39510) Fixed pipelines formatting (elastic#39513) Update filebeat pipeline to match Jenkins steps (elastic#39261) Add error check to groupToEvents so we don't blindly add error values (elastic#39404) Remove fields not needed for session view in add_session_view processor (elastic#39500) `aws-s3` input: Split S3 poller and SQS reader into explicit input objects (elastic#39353) ci(jenkins): remove post-build notifications (elastic#39483) [DOCS] Add the `read_pipeline` cluster privilege for winlogbeat and the `auto_configure` index privilege to beats documentation (elastic#38534) ...
Proposed commit message
Explicitly set
DOCKER_PULL
,RACE_DETECTOR
andTEST_COVERAGE
variables for pipelinesThe previous approach is unobvious and error-prone
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Relates https://github.com/elastic/ingest-dev/issues/3303