-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for shards total count in Elasticsearch Module #38891
Added support for shards total count in Elasticsearch Module #38891
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES: elastic/elasticsearch#107471 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have reviewed this more carefully yesterday!
We first need to wrap the access in a c.Dict
to go into indices.shard_stats
in the response, where we'll then find the field total_count
. We also make that Dict
optional so in case it's not there (as in older versions) we just skip grabbing that stat.
This should make the tests pass.
Co-authored-by: Milton Hultgren <[email protected]>
Hi,
I just added the support for the
shards_stats.total_count
which can be nice for alerting, since a lot of shards on a single node can impact performance.Question: if I fix it here, that means it is fixed for the Elastic Agent integration package as well?
Retrieves:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.