-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow -
in Apache access log byte count
#3863
Conversation
This addresses #3833. |
jenkins, retest it please |
Could you please add CHANGELOG entry? |
@exekias I guess, though what should it look like? Which version(s)? Most recent release is 5.3.0, and the CHANGELOG here on master doesn't even cover that. |
Just add it in HEAD section, we will manage that in the backport |
@exekias done |
Thanks for the fix @cwurm. I didn't use the |
@tsg We could take the grok pattern behind |
* Allow in Apache access log byte count (cherry picked from commit a083077)
Allows a
-
instead of a number for the byte sent part of the Apache access log, as described in http://httpd.apache.org/docs/current/mod/mod_log_config.htmlIn contrast, Nginx will always output
0
- so no need to change anything there.There are a few more pieces in the Grok pattern that are not quite in line with what Apache can produce. The Elasticsearch grok processor inherited a list of patterns from Logstash. One of them being
COMBINEDAPACHELOG
, we might want to mirror that in Filebeat. I guess that might be a more intrusive change, while this PR as-is can do no harm and should be fully backward compatible.