Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/http_endpoint: generalise event path using CEL #38193

Merged
merged 3 commits into from
Mar 13, 2024
Merged

x-pack/filebeat/input/http_endpoint: generalise event path using CEL #38193

merged 3 commits into from
Mar 13, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 6, 2024

Proposed commit message

Allow users to handle events where multiple events are provided via single JSON objects in an array field. This is enabled by providing an optional CEL program with only minimal support for CEL evaluations; no extensions from the mito lib extensions are made available.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Service Integrations Security Service Integrations Team labels Mar 6, 2024
@efd6 efd6 self-assigned this Mar 6, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 6, 2024
@efd6 efd6 force-pushed the 37910-http_endpoint branch from 14c2a04 to 11031ab Compare March 6, 2024 03:13
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 6, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 140 min 49 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review March 6, 2024 06:58
@efd6 efd6 requested a review from a team as a code owner March 6, 2024 06:58
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 force-pushed the 37910-http_endpoint branch 2 times, most recently from 732061d to 7ffb35a Compare March 6, 2024 08:40
ShourieG
ShourieG reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 Linter errors & Conflict needs to be resolved, otherwise LGTM

efd6 added 2 commits March 13, 2024 20:34
@efd6
x-pack/filebeat/input/http_endpoint: generalise event path using CEL
6c631a8 
Allow users to handle events where multiple events are provided via single JSON
objects in an array field. This is enabled by providing an optional CEL program
with only minimal support for CEL evaluations; no extensions from the mito lib
extensions are made available.
@efd6
address pr comment
390abde
@efd6 efd6 force-pushed the 37910-http_endpoint branch from 7ffb35a to 390abde Compare March 13, 2024 10:05
ShourieG
ShourieG approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @efd6

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @efd6

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @efd6

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @efd6

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 13, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @efd6

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 13, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @efd6

@efd6 efd6 enabled auto-merge (squash) March 13, 2024 20:40
@efd6 efd6 merged commit fb2594a into elastic:main Mar 13, 2024
35 of 40 checks passed
@efd6 efd6 mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy left review comments

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] http_endpoint - make input compatible with AWS Kinesis http delivery
4 participants
@efd6 @elasticmachine @kcreddy @ShourieG