Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13](backport #38181) x-pack/filebeat/input/{cel,websocket}: prevent addition of regexp extension when no patterns are provided #38192

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 6, 2024

This is an automatic backport of pull request #38181 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…ension when no patterns are provided (#38181)

In the case of cel, the extension was always being added, and then was
conditionally added when a pattern was configured, resulting in a failed
configuration. In the case of websocket the conditional addition was not
being performed, so no failure occurred, but additional look-up load was
being added. So unify the approaches to the correct conditional addition.

(cherry picked from commit 0797a64)
@mergify mergify bot requested a review from a team as a code owner March 6, 2024 01:43
@mergify mergify bot added the backport label Mar 6, 2024
@mergify mergify bot assigned efd6 Mar 6, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2024
@botelastic
Copy link

botelastic bot commented Mar 6, 2024

This pull request doesn't have a Team:<team> label.

@efd6 efd6 enabled auto-merge (squash) March 6, 2024 01:43
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-03-06T01:43:34.505+0000

  • Duration: 136 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 3314
Skipped 180
Total 3494

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit 072f00e into 8.13 Mar 6, 2024
18 of 21 checks passed
@efd6 efd6 deleted the mergify/bp/8.13/pr-38181 branch March 6, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants