-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use rate limiter with all interactions with Azure Monitoring API #38127
Conversation
The metricset uses multiple API endpoint, so we need to double-check if the max request rate applies to all endpoints or single ones.
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💚 Build Succeeded
cc @zmoog |
💚 Build Succeeded
cc @zmoog |
💚 Build Succeeded
cc @zmoog |
💚 Build Succeeded
cc @zmoog |
💚 Build Succeeded
cc @zmoog |
💚 Build Succeeded
cc @zmoog |
@zmoog This looks helpful, thank you! We are seeing lot of throttling errors and I would hope your PR can reduce the pain a bit. Beyond that, have you considered to move to the Azure Monitor batch API? It offers much higher limits and should be less affected by throttling. https://learn.microsoft.com/en-us/azure/azure-monitor/service-limits |
@StephanErb, thanks for sharing the link to Azure Monitor Batch API! It seems a great tool for efficiently getting metrics values and reducing the number of API calls. The Azure Monitor metricset performs other API calls to list the resources and collect the existing metrics for each resource. Then, it collects the value for each metric. The team is working on this, and we'll look more and update the PR soon. |
Closing this PR in favour of #38294 using a different approach. |
Proposed commit message
The metricset uses multiple API endpoint, so we need to double-check if the max request rate applies to all endpoints or single ones.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs