metricbeat: add password for redis module in doc #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
suggested changes
Mar 15, 2017
metricbeat/metricbeat.full.yml
Outdated
| @@ -284,6 +284,9 @@ metricbeat.modules: | |||
| # Redis hosts | |||
| #hosts: ["127.0.0.1:6379"] | |||
|
|
|||
| # Password to authenticate to the hosts | |||
There was a problem hiding this comment.
The password is already available on line 308. I think it needs to be added to the docs instead.
added 2 commits
March 15, 2017 16:48
…into doc/metricbeat_redis_password
|
I ran |
added 3 commits
March 15, 2017 17:26
…into doc/metricbeat_redis_password
…into doc/metricbeat_redis_password
|
@7AC Thanks for the fix. We should backport this to 5.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.