Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gpfsbeat line #3736

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Added gpfsbeat line #3736

merged 1 commit into from
Mar 10, 2017

Conversation

itkovian
Copy link
Contributor

@itkovian itkovian commented Mar 9, 2017

No description provided.

@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@tsg
Copy link
Contributor

tsg commented Mar 10, 2017

Nice! Would you be interested in also contributing a Metricbeat module for this one?

@tsg tsg merged commit fbebb41 into elastic:master Mar 10, 2017
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Mar 16, 2017
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Mar 16, 2017
ruflin pushed a commit that referenced this pull request Mar 17, 2017
ruflin pushed a commit that referenced this pull request Mar 17, 2017
@itkovian
Copy link
Contributor Author

itkovian commented Apr 6, 2017

Well, this started out as a patch to metric beat, but then I reread the docs, and it seemed more prudent to have this as a separate beat. What would be the advantage/disadvantage having it in metric beat?

@ruflin
Copy link
Contributor

ruflin commented Apr 10, 2017

Having it in metricbeat or based on metricbeat would mean you don't have to implement the scheduling etc. yourself. Also if it would be in metricbeat itself it would mean users can enable the module with just a config change instead of having to download an other beat.

Curious to hear which part in the docs made you think it is better to go with a completely new beat?

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants