Add memcached module with stats metricset #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
memcached-module
branch
5 times, most recently
from
46100ac
to
93b13d3
Compare
|
jenkins, retest it |
|
jenkins, retest it |
tsg
reviewed
Mar 14, 2017
CHANGELOG.asciidoc
Outdated
| @@ -98,6 +98,7 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff] | |||
| - The Docker, Kafka, and Prometheus modules are now Beta, instead of experimental. {pull}3525[3525] | |||
| - The HAProxy module is now GA, instead of experimental. {pull}3525[3525] | |||
| - Add the ability to collect the environment variables from system processes. {pull}3337[3337] | |||
| - Add memcached module with stats metricset. | |||
tsg
reviewed
Mar 14, 2017
metricbeat/docs/fields.asciidoc
Outdated
|
|
||
|
|
||
| [float] | ||
| === memcached.stats.uptime |
There was a problem hiding this comment.
Is this seconds? Should we have it as uptime.secs then?
There was a problem hiding this comment.
yes, changed it to uptime.sec.
tsg
reviewed
Mar 14, 2017
|
|
||
| func New(base mb.BaseMetricSet) (mb.MetricSet, error) { | ||
|
|
||
| logp.Warn("BETA: The docker container metricset is beta") |
ruflin
force-pushed
the
memcached-module
branch
from
d4107de
to
8c4a0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new module "memcached" was added which gathers metrics from https://memcached.org/. The
statscommand is used in thestatsmetricset to gather all infos about the service.