-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/module/cisco Fix Cisco module Grok pattern #36326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhapas
added
bug
Team:Security-External Integrations
backport-v8.9.0
Automated backport with mergify
labels
Aug 15, 2023
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Aug 15, 2023
bhapas
force-pushed
the
cisco-grok-issue-36325
branch
from
August 15, 2023 13:42
1882a19
to
8efb44e
Compare
Collaborator
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
bhapas
changed the title
x-paxk/filebeat/module/cisco Fix Cisco module Grok pattern
x-pack/filebeat/module/cisco Fix Cisco module Grok pattern
Aug 15, 2023
efd6
reviewed
Aug 15, 2023
x-pack/filebeat/module/cisco/shared/ingest/asa-ftd-pipeline.yml
Outdated
Show resolved
Hide resolved
efd6
approved these changes
Aug 16, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
* Fix Cisco module Grok pattern * Fix PR comments (cherry picked from commit ff96091)
bhapas
added a commit
that referenced
this pull request
Aug 16, 2023
…36330) * Fix Cisco module Grok pattern * Fix PR comments (cherry picked from commit ff96091) Co-authored-by: Bharat Pasupula <[email protected]>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…6326) * Fix Cisco module Grok pattern * Fix PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fix Grok pattern in Cisco shared ingest pipeline.
[ .... ]
but the hyphen character is not escaped.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Download Filebeat, configure it to connect to an Elasticsearch cluster and run
filebeat setup -e
. Wait for all the Filebeat assets (dashboards, ingest pipelines, etc.) to be loaded.Check the Elasticsearch logs and observe the above warning message.
Delete all the ingest pipelines related to Filebeat (can be done in batch through Kibana > Stack Management > Ingest Pipelines)
Modify the file
filebeat/module/cisco/shared/ingest/asa-ftd-pipeline.yml
to replace the 5 occurrences:FROM:
TO:
run
filebeat setup -e
. Wait for all the Filebeat artefacts (dashboards, ingest pipelines, etc.) to be loaded.Check the Elasticsearch: above warning message is no longer observed.
Related issues