Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/module/juniper: fix handling of jrx structured data #36308

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 13, 2023

Proposed commit message

Previously, the leading word was ignored. I all our test cases this was in the form /junos@(\d+.){5}\d+/. When this value is not present, we lose the first structured data value, so be more careful in assessing whether the first element should be discarded.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Aug 13, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 13, 2023
Previously, the leading word was ignored. I all our test cases this was
in the form /junos@(\d+\.){5}\d+/. When this value is not present, we
lose the first structured data value, so be more careful in assessing
whether the first element should be discarded.
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-13T22:09:56.405+0000

  • Duration: 76 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 3128
Skipped 176
Total 3304

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review August 13, 2023 23:46
@efd6 efd6 requested a review from a team as a code owner August 13, 2023 23:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit e66e0cb into elastic:main Aug 14, 2023
mergify bot pushed a commit that referenced this pull request Aug 14, 2023
…36308)

Previously, the leading word was ignored. I all our test cases this was
in the form /junos@(\d+\.){5}\d+/. When this value is not present, we
lose the first structured data value, so be more careful in assessing
whether the first element should be discarded.

(cherry picked from commit e66e0cb)
efd6 added a commit that referenced this pull request Aug 14, 2023
…36308) (#36311)

Previously, the leading word was ignored. I all our test cases this was
in the form /junos@(\d+\.){5}\d+/. When this value is not present, we
lose the first structured data value, so be more careful in assessing
whether the first element should be discarded.

(cherry picked from commit e66e0cb)

Co-authored-by: Dan Kortschak <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
…lastic#36308)

Previously, the leading word was ignored. I all our test cases this was
in the form /junos@(\d+\.){5}\d+/. When this value is not present, we
lose the first structured data value, so be more careful in assessing
whether the first element should be discarded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.10-candidate backport-v8.9.0 Automated backport with mergify bug Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat Juniper SRX Pipeline issue - Trimmed source address
3 participants