Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docs links #35744

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Fix Docs links #35744

merged 2 commits into from
Jun 13, 2023

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Jun 12, 2023

What does this PR do?

Reverts the Docs link from BEATNAME/modules.d/MODULE.yml.disabled to use master instead of main introduced by #35226.
It also reverts #35693 as it did not fix the problem.

Why is it important?

The links are broken

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@AndersonQ AndersonQ added docs Team:Elastic-Agent Label for the Agent team backport-skip Skip notification from the automated backport with mergify labels Jun 12, 2023
@AndersonQ AndersonQ requested a review from cmacknz June 12, 2023 13:35
@AndersonQ AndersonQ self-assigned this Jun 12, 2023
@AndersonQ AndersonQ requested review from a team as code owners June 12, 2023 13:35
@AndersonQ AndersonQ requested a review from belimawr June 12, 2023 13:35
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 12, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-12T13:35:56.591+0000

  • Duration: 112 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 27337
Skipped 2009
Total 29346

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@AndersonQ AndersonQ enabled auto-merge (squash) June 12, 2023 17:09
@AndersonQ AndersonQ disabled auto-merge June 12, 2023 17:15
@AndersonQ AndersonQ enabled auto-merge (squash) June 12, 2023 17:15
@AndersonQ
Copy link
Member Author

@cmacknz could you force merge it? the check not passing is the linter complaining about things I did not change :/

@cmacknz
Copy link
Member

cmacknz commented Jun 12, 2023

You are blocked by the code owner check from SEI. The lint check failing doesn't block merge.

Waiting on code owner review from elastic/security-external-integrations

@AndersonQ AndersonQ merged commit 4af3e60 into elastic:main Jun 13, 2023
@AndersonQ AndersonQ deleted the fix-docs-link branch June 21, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify docs Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants