Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Update gval to latest version to improve Heartbeat JSON parsing #35636

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

justinkambic
Copy link
Contributor

What does this PR do?

Updates gval module to the latest version.

Why is it important?

Updates gval to latest version with the hope that parsing will be improved for users.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Make sure JSON functions are evaluated properly

How to test this PR locally

You can create a monitor like:

- type: http
  id: sendgrid-smtp-status
  name: Check Sendgrid SMTP
  fields:
    component: "sendgrid-smtp-status"
  schedule: '@every 10s'
  response.include_body: always
  tags: ["sendgrid-smtp"]
  urls:
    - https://status.sendgrid.com/api/v2/components.json
  check.request.method: GET
  check.response:
    status: [200]
    json:
      - description: Check Sendgrid SMTP status
        expression: '$.components[?(@.name == "SMTP" && @.status == "operational")] != []'

It should have a status of up

Use cases

Ensure we have the latest version of the JSON parser we use.

Screenshots

Logs

@justinkambic justinkambic requested a review from a team as a code owner May 31, 2023 20:03
@justinkambic justinkambic self-assigned this May 31, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 31, 2023
@mergify
Copy link
Contributor

mergify bot commented May 31, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @justinkambic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T20:57:26.322+0000

  • Duration: 103 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 27307
Skipped 2007
Total 29314

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gval_1.2.2 upstream/gval_1.2.2
git merge upstream/main
git push upstream gval_1.2.2

@andrewvc andrewvc self-requested a review June 2, 2023 20:28
@andrewvc andrewvc added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team :uptime labels Jun 2, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 2, 2023
@pierrehilbert pierrehilbert requested review from fearful-symmetry and removed request for pierrehilbert June 5, 2023 06:56
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jun 5, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@andrewvc
Copy link
Contributor

andrewvc commented Jun 5, 2023

FYI, this needed make update in the root of beats. I've done that and pushed.

@pierrehilbert was there a reason you added @fearful-symmetry onto this? I only heartbeat uses gval AFAICT

@pierrehilbert
Copy link
Collaborator

Hey @andrewvc, my bad I didn't see that this change was only touching the go.mod and wanted to have someone from the team looking at it with the new process process in place.

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gval_1.2.2 upstream/gval_1.2.2
git merge upstream/main
git push upstream gval_1.2.2

@justinkambic justinkambic enabled auto-merge (squash) June 7, 2023 21:00
@justinkambic justinkambic merged commit f694f39 into elastic:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement Heartbeat Team:Elastic-Agent Label for the Agent team Team:obs-ds-hosted-services Label for the Observability Hosted Services team :uptime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants