-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Update gval to latest version to improve Heartbeat JSON parsing #35636
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/uptime (Team:Uptime) |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
FYI, this needed @pierrehilbert was there a reason you added @fearful-symmetry onto this? I only heartbeat uses |
Hey @andrewvc, my bad I didn't see that this change was only touching the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is now in conflicts. Could you fix it? 🙏
|
What does this PR do?
Updates
gval
module to the latest version.Why is it important?
Updates
gval
to latest version with the hope that parsing will be improved for users.Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
You can create a monitor like:
It should have a status of
up
Use cases
Ensure we have the latest version of the JSON parser we use.
Screenshots
Logs