-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use replicaset and Job MetaGen based on watchers #35483
Conversation
Signed-off-by: ChrsMark <[email protected]>
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
This pull request is now in conflicts. Could you fix it? 🙏
|
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
@gizas it seems that I don't have permissions to merge this one? Have we changed anything? BTW both failures are unrelated to this PR's changes. EDIT: e2e testing suite was using k8s manifests that were missing the required Roles to |
@elastic/elastic-agent-data-plane could you approve/merge this one please? |
/test |
/package |
1 similar comment
/package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The linter issues seem to be false-positives.
e2e tests passed. Merging this one. |
Respective PR for elastic/elastic-agent-autodiscover#44 part of elastic/elastic-agent-autodiscover#31.
Blocked until elastic/elastic-agent-autodiscover#44 is merged and a new version of the autodiscovery library is released.
How to test this PR
DEV=true PLATFORMS=linux/amd64 PACKAGES=docker mage -v package
build/package/metricbeat-oss/metricbeat-oss-linux-amd64.docker/docker-build
directory.kind
cluster usingkind load docker-image custom-mb
add_kubernetes_metadata
processor.