winlogbeat/sys/wineventlog: don't use claimed buffer use value #35437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Winlogbeat
8.9-candidate
backport-v8.8.0
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
EvtFormatMessage appears to sometimes claim that more buffer was used during a rendering call than was or exists, so do not use this value except in the query to get the needed buffer size.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
May 12, 2023
EvtFormatMessage appears to sometimes claim that more buffer was used during a rendering call than was or exists, so do not use this value except in the query to get the needed buffer size. (cherry picked from commit fd7b89c)
efd6
added a commit
that referenced
this pull request
May 14, 2023
… (#35442) EvtFormatMessage appears to sometimes claim that more buffer was used during a rendering call than was or exists, so do not use this value except in the query to get the needed buffer size. (cherry picked from commit fd7b89c) Co-authored-by: Dan Kortschak <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
EvtFormatMessage appears to sometimes claim that more buffer was used during a rendering call than was or exists, so do not use this value except in the query to get the needed buffer size.
6 tasks
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
EvtFormatMessage appears to sometimes claim that more buffer was used during a rendering call than was or exists, so do not use this value except in the query to get the needed buffer size.
It is a subset of the change in #34005. The remainder of the removal of the passed buffer is left for later work.
Why is it important?
Winlogbeat will sometimes panic due to a bounds error.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs