[WIP] Restructure Harvester and Prospector Shutdown #3538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
discuss
ruflin
changed the title
ruflin
force-pushed
the
track-harvesters
branch
5 times, most recently
from
ef8fdde
to
a67641d
Compare
There are two options for stopping a harvester or a prospector. Either the harvester and prospector finish sending all events and stop themself or they are killed because the output is blocking. In case of shutting down filebeat without using `shutdown_timeout` filebeat is expected to shut down as fast as possible. This means channels are directly closed and the events are not passed through to the registry. In case of dynamic prospector reloading, prospectors and harvesters must be stopped properly as otherwise no new harvester for the same file can be started. So far the following changes were made: * Introduce harvester tracking in prospector to better control / manage the harvesters * Use `beatDone` channel coming from the beat itself for direct shutdown as this channel is closed when the beat is stopped. * Introduce more done channels in prospector to make shutdown more fine grained * Add system tests to verify new behaviour TODO * Make sure all events are drained from channel to not guarantee that state updates will be persisted.
ruflin
force-pushed
the
track-harvesters
branch
from
a67641d
to
b6af35f
Compare
|
Closing in favor of #3563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two options for stopping a harvester or a prospector. Either the harvester and prospector finish sending all events and stop themself or they are killed because the output is blocking.
In case of shutting down filebeat without using
shutdown_timeoutfilebeat is expected to shut down as fast as possible. This means channels are directly closed and the events are not passed through to the registry.In case of dynamic prospector reloading, prospectors and harvesters must be stopped properly as otherwise no new harvester for the same file can be started.
So far the following changes were made:
beatDonechannel coming from the beat itself for direct shutdown as this channel is closed when the beat is stopped.TODO