Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edits for load and socket metricset docs #3495

Merged
merged 2 commits into from
Feb 1, 2017

Conversation

dedemorton
Copy link
Contributor

Adds a few edits for consistency and clarity.

These edits are tracked in the doc meta issue #3329.

@andrewkroh
Copy link
Member

The changes LGTM, but the build failed with:

metricbeat/docs/fields.asciidoc: needs update
make: *** [check] Error 1

I think you need to run make collect.

@ruflin
Copy link
Member

ruflin commented Jan 31, 2017

Best directly run make update that will also cover make collect.

@dedemorton
Copy link
Contributor Author

@andrewkroh or @ruflin Should be ready now. I did run make collect but it sounds like make update is the secret sauce. :-P

@ruflin ruflin merged commit 0e6fbb0 into elastic:master Feb 1, 2017
ruflin pushed a commit that referenced this pull request Feb 6, 2017
* Add edits for load and socket metricset docs

* Remove step to set default index pattern

* Add new config options to the decode_json_fields processor docs

* Run make update
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…3512) (elastic#3529)

* Add edits for load and socket metricset docs

* Remove step to set default index pattern

* Add new config options to the decode_json_fields processor docs

* Run make update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants