-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update elastic-agent-shipper-client deps #34596
update elastic-agent-shipper-client deps #34596
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Alright, CI errors appear to be actually related, looking over them... |
Alright, I'm not 100% sure if some of these errors. The |
The protojson package serializes the message to the structure below which is syntactically valid JSON for example: {
"timestamp": "2023-02-16T18:54:25Z",
"source": {},
"dataStream": {},
"fields": {
"data": {
"field": {
"structValue": {}
}
}
}
}
|
Yah, that's what I thought, just wanted to make sure. |
Want to update the PR with fixes before the long weekend, but right now we're in a weird state where we're not testing certain things like retries/dropped events, since the marshaling code is much more aggressive with not erring out. Will have to re-do some of the mock shipper server so I can get events to drop. I also suspect that since the event marshaler is more capable of handling map types, there might be some redundant code. Not sure if we want to deal with that in this PR or do a follow-up. |
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
1 similar comment
/test |
E2E failures are unrelated, merging |
* update elastic-agent-shipper-client deps * remove tests depending on failure * remove debug lines * update tests * try to make linter happy (cherry picked from commit b5c00fd)
* update elastic-agent-shipper-client deps * remove tests depending on failure * remove debug lines * update tests * try to make linter happy (cherry picked from commit b5c00fd)
* update elastic-agent-shipper-client deps * remove tests depending on failure * remove debug lines * update tests * try to make linter happy (cherry picked from commit b5c00fd) Co-authored-by: Alex K <[email protected]>
* update elastic-agent-shipper-client deps * remove tests depending on failure * remove debug lines * update tests * try to make linter happy
What does this PR do?
This updates the
elastic-agent-shipper-client
deps to pull in the recent bugfixes.Why is it important?
This upstream change fixes a number of bugs.