Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate coverage report after fixing file permissions #3445

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

andrewkroh
Copy link
Member

This changes the Makefile to run coverage-report after fix-permissions. This allows coverage-report to be able to fully traverse the contents the build dir.

This changes the Makefile to run coverage-report after fix-permissions. This allows coverage-report to be able to fully traverse the contents the build dir.
@andrewkroh
Copy link
Member Author

This PR doesn't fix the errors in the logs, but it should fix the coverage reports.

This line executes for each make invocation and is what generates the "Permission denied" warnings.

make fix-permissions corrects the permissions for files in the build dir. But there are still files in the repo that are owned by root after running the build in Docker. Those files and dirs are:

./filebeat/tests/system/test_load.pyc
./filebeat/tests/system/test_harvester.pyc
./filebeat/tests/system/filebeat.pyc
./filebeat/tests/system/test_fields.pyc
./filebeat/tests/system/test_multiline.pyc
./filebeat/tests/system/test_shutdown.pyc
./filebeat/tests/system/test_processors.pyc
./filebeat/tests/system/test_registrar.pyc
./filebeat/tests/system/test_modules.pyc
./filebeat/tests/system/test_publisher.pyc
./filebeat/tests/system/test_prospector.pyc
./filebeat/tests/system/test_reload.pyc
./filebeat/tests/system/test_json.pyc
./filebeat/tests/system/test_crawler.pyc
./filebeat/tests/system/test_migration.pyc
./filebeat/tests/files/logs/nasa-50k.log
./filebeat/data
find: `./filebeat/data': Permission denied
./filebeat/filebeat.test
./metricbeat/tests/system/test_kafka.pyc
./metricbeat/tests/system/test_base.pyc
./metricbeat/tests/system/metricbeat.pyc
./metricbeat/tests/system/test_docker.pyc
./metricbeat/tests/system/test_processors.pyc
./metricbeat/tests/system/test_mongodb.pyc
./metricbeat/tests/system/test_haproxy.pyc
./metricbeat/tests/system/test_postgresql.pyc
./metricbeat/tests/system/test_config.pyc
./metricbeat/tests/system/test_zookeeper.pyc
./metricbeat/tests/system/test_redis.pyc
./metricbeat/tests/system/test_reload.pyc
./metricbeat/tests/system/test_prometheus.pyc
./metricbeat/tests/system/test_system.pyc
./metricbeat/tests/system/test_apache.pyc
./metricbeat/tests/system/test_mysql.pyc
./metricbeat/metricbeat.test
./metricbeat/data
find: `./metricbeat/data': Permission denied
./libbeat/dashboards/import_dashboards
./libbeat/tests/system/test_base.pyc
./libbeat/tests/system/beat/beat.pyc
./libbeat/tests/system/beat/__init__.pyc
./libbeat/tests/system/base.pyc
./libbeat/tests/system/test_dashboard.pyc
./libbeat/libbeat.test
./libbeat/data
find: `./libbeat/data': Permission denied

Should we expand fix-permissions to cover these files/dirs too? Maybe something like find . -uid 0 -exec chown myuid:mygid {} \;

@ruflin ruflin merged commit f1b59cd into elastic:master Jan 24, 2017
@ruflin
Copy link
Member

ruflin commented Jan 24, 2017

@andrewkroh +1 on expanding it to all the files with the "wrong" permissions.

@andrewkroh andrewkroh deleted the bugfix/coverage-report branch March 31, 2017 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants