Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cookie cutter template for beat #3435

Closed
wants to merge 1 commit into from

Conversation

johnthedev97
Copy link

Added cookie cutter.json
Convert all template variables into cookiecutter namespace and inside double braces

Convert all template variables into cookie cutter namespace and double
braces
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@johnthedev97
Copy link
Author

According to documentation here (https://www.elastic.co/guide/en/beats/libbeat/current/newbeat-generate.html) the command to generate beat is ''cookiecutter $GOPATH/src/github.com/elastic/beats/generate/beat". But the travis build seems to be generating the beat by running 'beat.py' instead of the documented method, which is the expected method?

@ruflin
Copy link
Member

ruflin commented Jan 23, 2017

@johnthedev97 It depends on the version. In master I started to remove the dependency on cookiecutter as our templates are so basic it is overkill to require people to install an extra tool. And not using cookiecutter allows us to do some additional checks. Here are the docs based on master: https://www.elastic.co/guide/en/beats/libbeat/master/newbeat-generate.html

Until branch 5.2 cookiecutter is used.

@ruflin
Copy link
Member

ruflin commented Jan 25, 2017

I'm closing this as we are moving away from cookiecutter.

@johnthedev97 Keep an eye on #3452 as this PR contains the next major changes to the generator.

@ruflin ruflin closed this Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants