Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker client to most recent version #3398

Merged
merged 3 commits into from
Jan 18, 2017

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jan 18, 2017

The docker client now depends on the docker repository which means we have to add the docker repo. This adds quite a few dependencies. To reduce the number of dependencies, the docker repository was modified manually and all not required parts were removed. On the client side some code parts were removed which are not needed for our read only use case.

Long term goal is to either use the internal docker client or use our own implementation of a HTTP client that fetches data from the socket or rest API and uses our internal schema.

@ruflin ruflin added the in progress Pull request is currently in progress. label Jan 18, 2017
@ruflin ruflin force-pushed the update-docker-client branch 2 times, most recently from 7c9f14e to d04e904 Compare January 18, 2017 09:31
@ruflin ruflin added review and removed in progress Pull request is currently in progress. labels Jan 18, 2017
The docker client now depends on the docker repository which means we have to add the docker repo. This adds quite a few dependencies. To reduce the number of dependencies, the docker repository was modified manually and all not required parts were removed. On the client side some code parts were removed which are not needed for our read only use case.

Long term goal is to either use the internal docker client or use our own implementation of a HTTP client that fetches data from the socket or rest API and uses our internal schema.
add removal of .tar files to cleanup script
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope the tests will be passing :)

@andrewkroh
Copy link
Member

There looks to be some stuff under a "testfiles" dir that can be removed.

@andrewkroh andrewkroh merged commit fb3ad7e into elastic:master Jan 18, 2017
@monicasarbu monicasarbu deleted the update-docker-client branch January 23, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants