Add support for excluded paths in packaging #33894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file.
rdner
requested review from
faec and
leehinman
and removed request for
a team
botelastic
bot
added
the
needs_team
rdner
added
backport-7.17
rdner
requested review from
vigneshshanmugam and
cmacknz
and removed request for
faec and
leehinman
rdner
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
cmacknz
approved these changes
Nov 30, 2022
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Add support for excluded paths in packaging After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file. * Fix linting issues * Fix one more linting issue (cherry picked from commit 3198a68) # Conflicts: # dev-tools/packaging/package_test.go
This was referenced Nov 30, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Add support for excluded paths in packaging After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file. * Fix linting issues * Fix one more linting issue (cherry picked from commit 3198a68)
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* Add support for excluded paths in packaging After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file. * Fix linting issues * Fix one more linting issue (cherry picked from commit 3198a68)
cmacknz
added a commit
that referenced
this pull request
Nov 30, 2022
…33900) * Add support for excluded paths in packaging (#33894) * Add support for excluded paths in packaging After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file. * Fix linting issues * Fix one more linting issue (cherry picked from commit 3198a68) # Conflicts: # dev-tools/packaging/package_test.go * Resolve merge conflicts. Co-authored-by: Denis <[email protected]> Co-authored-by: Craig MacKenzie <[email protected]>
rdner
added a commit
that referenced
this pull request
Dec 1, 2022
* Add support for excluded paths in packaging After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file. * Fix linting issues * Fix one more linting issue (cherry picked from commit 3198a68) Co-authored-by: Denis <[email protected]>
rdner
added a commit
that referenced
this pull request
Dec 1, 2022
* Add support for excluded paths in packaging After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file. * Fix linting issues * Fix one more linting issue (cherry picked from commit 3198a68) Co-authored-by: Denis <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Add support for excluded paths in packaging After an update in heartbeat we have have a path like `usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.yml` which matches the `configFilePattern` which causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file. * Fix linting issues * Fix one more linting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for excluded paths when testing the packaging.
Why is it important?
After an update in heartbeat we have have a path like
usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/templates/lightweight/heartbeat.ymlwhich matches theconfigFilePatternwhich causes a permission check which the file does not satisfy. It has nothing to do with the actual heartbeat configuration file.See the failure here https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fpackaging/detail/PR-33843/4/pipeline/150/
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.