Set config file mode to 0600 in packages #3382
Conversation
|
jenkins, package it |
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/blakesmith/ar" |
There was a problem hiding this comment.
Could we add a vendor directory to the dev-tools directory? I would prefer if we don't mix vendor packages for tools with actual libbeat / beats dependencies. This makes it easier to track where a dependency belongs to.
Long term I'm thinking also to move dependencies which only belong to one beat into the beat if possible.
There was a problem hiding this comment.
Yeah, I can move these to dev-tools. I was thinking about that when I added them because glide was giving lots of errors and also because I wanted it to be clear that these deps were not used in any Beat that we release.
There was a problem hiding this comment.
I update the PR to move the dependencies to ./dev-tools/vendor.
| @@ -105,7 +105,7 @@ import: | |||
| - zlib | |||
| - package: github.com/klauspost/cpuid | |||
| version: v1.0 | |||
| - package: https://github.com/go-inf/inf | |||
| - package: github.com/go-inf/inf | |||
This PR changes the main config file (<beatname>.yml) from 0644 to 0600. It adds a test that checks all RPM, deb, tar.gz, and zip files to ensure that the config file has the correct file mode.
andrewkroh
force-pushed
the
feature/config-0600
branch
from
206a533 to
c966fca
Compare
|
jenkins, package it |
| @@ -0,0 +1,18 @@ | |||
| package: github.com/elastic/beats/dev-tools | |||
| import: [] | |||
| testImports: | |||
There was a problem hiding this comment.
wasn't aware of this glide feature.
|
@monicasarbu @andrewkroh One thing I just realised now is that the next time we build the NOTICE file, it will also include the LICENSES from these dependencies. But I think we should leave this out, means excluding |
This PR changes the main config file (.yml) from 0644 to 0600. It adds a test that checks all RPM, deb, tar.gz, and zip files to ensure that the config file has the correct file mode.