Update test versions of NGINX, Apache and MongoDB #33789

rdner · 2022-11-23T11:03:44Z

What does this PR do?

The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020).

We started having problems with expired GPG keys when installing dependencies in our Docker files.

Why is it important?

Our CI is currently failing with:

[2022-11-23T02:15:50.651Z] W: GPG error: http://security.debian.org/ jessie/updates InRelease: The following signatures were invalid: KEYEXPIRED 1668892417 The following signatures couldn't be verified because the public key is not available: NO_PUBKEY AA8E81B4331F7F50
[2022-11-23T02:15:50.651Z] W: GPG error: http://nginx.org/ jessie InRelease: The following signatures were invalid: KEYEXPIRED 1471427554
[2022-11-23T02:15:50.651Z] W: GPG error: http://httpredir.debian.org/ jessie Release: The following signatures were invalid: KEYEXPIRED 1668891673

Author's Checklist

Metricbeat NGINX tests passed
Metricbeat Apache tests passed
Metricbeat MongoDB tests passed
Closes Logstash integration tests are flaky #33230

elasticmachine · 2022-11-23T11:03:47Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine · 2022-11-23T12:23:02Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-11-28T15:30:50.308+0000
Duration: 118 min 33 sec

Test stats 🧪

Test	Results
Failed	0
Passed	24114
Skipped	1954
Total	26068

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

rdner · 2022-11-23T20:37:03Z

metricbeat/module/apache/_meta/Dockerfile

@@ -1,6 +1,5 @@
 ARG APACHE_VERSION=${APACHE_VERSION}
 FROM httpd:$APACHE_VERSION
-RUN sed -i "/jessie-updates/d" /etc/apt/sources.list
-RUN apt-get update && apt-get install -y curl
+RUN apt update && yes | apt install curl


This is different on purpose. yes | also allows to install packages without authentication in case of expired keys. The keys in Jessie are expired at the moment and we need this Debian version for testing old log format for httpd <= 2.4.12. So either we have to update the keys as one of the steps or just accept the prompt to install without authentication.

The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020). We started having problems with expired GPG keys when installing dependencies in our Docker files. Add the missing MPM module and the `ServerName` directive for Apache.

rdner · 2022-11-24T19:16:09Z

metricbeat/module/logstash/logstash_integration_test.go

+			require.Eventually(t, func() bool {
+				events, errs = mbtest.ReportingFetchV2Error(f)
+				return len(events) > 0 && len(errs) == 0
+			}, 30*time.Second, time.Second, "events cannot be empty: %v, %v", events, errs)


This test was flaky, sometimes Logstash returns 0 events the first time around.

andrewkroh · 2022-11-28T15:23:56Z

My mage is 1.13.0 and the Github action is running 1.14.0.

I noticed this too. There's a Makefile that predates using go install to install the versions from go.mod. So it has a statically defined 1.13 command in it. That should probably be changed over to to using go install without any version specifier.

beats/dev-tools/make/mage-install.mk

Line 1 in d49292d

MAGE_VERSION ?= v1.13.0

andrewkroh · 2022-11-28T15:24:39Z

make check and make check-default are passing on my machine, seems like there is something wrong with the Github action.

Same for me. I can't reproduce the diff that CI is giving for the NOTICE.

rdner · 2022-11-28T15:32:46Z

@andrewkroh I found the cause, it's because of:
#33832
elastic/elastic-agent-client#48

I've pinned the version in 4048b65

andrewkroh · 2022-11-28T15:38:28Z

😆 I just found it too.

github.com/elastic/[email protected]: invalid version: unknown revision 5f1e54f40d3e

Great!

cmacknz

Thanks for fighting through all this!

rdner · 2022-11-28T18:12:00Z

E2E test fails with

Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.6.0-SNAPSHOT

it's definitely unrelated to the change, I'm merging.

The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020). We started having problems with expired GPG keys when installing dependencies in our Docker files. Also: * Add the missing MPM module and the `ServerName` directive for Apache. * Add retries to Logstash tests because they are flaky * Do not install mage v1.14.0 * Update elastic-agent-client version to avoid broken agent dependency (cherry picked from commit 4f639d7) # Conflicts: # NOTICE.txt # go.mod # go.sum

The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020). We started having problems with expired GPG keys when installing dependencies in our Docker files. Also: * Add the missing MPM module and the `ServerName` directive for Apache. * Add retries to Logstash tests because they are flaky * Do not install mage v1.14.0 * Update elastic-agent-client version to avoid broken agent dependency (cherry picked from commit 4f639d7)

The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020). We started having problems with expired GPG keys when installing dependencies in our Docker files. Also: * Add the missing MPM module and the `ServerName` directive for Apache. * Add retries to Logstash tests because they are flaky * Do not install mage v1.14.0 * Update elastic-agent-client version to avoid broken agent dependency (cherry picked from commit 4f639d7) Co-authored-by: Denis <[email protected]>

…oDB (#33844) * Update test versions of NGINX, Apache and MongoDB (#33789) The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020). We started having problems with expired GPG keys when installing dependencies in our Docker files. Also: * Add the missing MPM module and the `ServerName` directive for Apache. * Add retries to Logstash tests because they are flaky * Do not install mage v1.14.0 * Update elastic-agent-client version to avoid broken agent dependency (cherry picked from commit 4f639d7) # Conflicts: # NOTICE.txt # go.mod # go.sum Co-authored-by: Denis <[email protected]>

…goDB (#33843) * Update test versions of NGINX, Apache and MongoDB (#33789) The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020). We started having problems with expired GPG keys when installing dependencies in our Docker files. Also: * Add the missing MPM module and the `ServerName` directive for Apache. * Add retries to Logstash tests because they are flaky * Do not install mage v1.14.0 * Update elastic-agent-client version to avoid broken agent dependency (cherry picked from commit 4f639d7) # Conflicts: # NOTICE.txt # go.mod # go.sum * Resolve conflicts * Rollback the client version update Co-authored-by: Denis <[email protected]>

The old tests were based on Debian Jessie released in April 2015 (end-of-life on June 30, 2020). We started having problems with expired GPG keys when installing dependencies in our Docker files. Also: * Add the missing MPM module and the `ServerName` directive for Apache. * Add retries to Logstash tests because they are flaky * Do not install mage v1.14.0 * Update elastic-agent-client version to avoid broken agent dependency

rdner added Metricbeat Metricbeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify labels Nov 23, 2022

rdner requested a review from a team as a code owner November 23, 2022 11:03

rdner self-assigned this Nov 23, 2022

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 23, 2022

rdner force-pushed the update-test-versions branch from 587679b to ce6b8f1 Compare November 23, 2022 18:44

rdner commented Nov 23, 2022

View reviewed changes

rdner requested a review from a team as a code owner November 24, 2022 09:24

rdner requested review from belimawr and fearful-symmetry and removed request for a team November 24, 2022 09:24

rdner requested review from a team as code owners November 24, 2022 10:23

rdner force-pushed the update-test-versions branch from 8d6338c to 2b17815 Compare November 24, 2022 10:45

rdner removed request for a team November 24, 2022 10:46

rdner force-pushed the update-test-versions branch from 4e17685 to 2b17815 Compare November 24, 2022 12:31

rdner marked this pull request as draft November 24, 2022 13:22

rdner removed request for belimawr and fearful-symmetry November 24, 2022 14:15

rdner force-pushed the update-test-versions branch from 8ec4529 to 6231062 Compare November 24, 2022 15:51

rdner force-pushed the update-test-versions branch from 6231062 to 38b7077 Compare November 24, 2022 15:55

rdner commented Nov 24, 2022

View reviewed changes

rdner marked this pull request as ready for review November 24, 2022 19:16

rdner requested a review from a team as a code owner November 24, 2022 19:16

rdner removed the request for review from a team November 25, 2022 12:34

Do not install mage v1.14.0

075e60f

andrewkroh approved these changes Nov 28, 2022

View reviewed changes

Update elastic-agent-client version to avoid broken agent dependency

4048b65

rdner mentioned this pull request Nov 28, 2022

mod: update elastic-agent-client past invalid elastic-agent dep commit #33832

Closed

6 tasks

cmacknz approved these changes Nov 28, 2022

View reviewed changes

cmacknz mentioned this pull request Nov 28, 2022

Logstash integration tests are flaky #33230

Closed

rdner mentioned this pull request Nov 28, 2022

Update the client version elastic/elastic-agent-shipper#189

Merged

This was referenced Nov 28, 2022

[libbeeat] add DropFields processor to js API #33458

Merged

Register the add_formatted_index as a usable processor. #33800

Merged

rdner merged commit 4f639d7 into elastic:main Nov 28, 2022

rdner deleted the update-test-versions branch November 28, 2022 18:12

mergify bot mentioned this pull request Nov 28, 2022

[7.17](backport #33789) Update test versions of NGINX, Apache and MongoDB #33843

Merged

mergify bot mentioned this pull request Nov 28, 2022

[8.5](backport #33789) Update test versions of NGINX, Apache and MongoDB #33844

Merged

mergify bot mentioned this pull request Nov 28, 2022

[8.6](backport #33789) Update test versions of NGINX, Apache and MongoDB #33845

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update test versions of NGINX, Apache and MongoDB #33789

Update test versions of NGINX, Apache and MongoDB #33789

rdner commented Nov 23, 2022 •

edited by cmacknz

Loading

elasticmachine commented Nov 23, 2022

elasticmachine commented Nov 23, 2022 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

rdner Nov 23, 2022

rdner Nov 24, 2022

andrewkroh commented Nov 28, 2022

andrewkroh commented Nov 28, 2022

rdner commented Nov 28, 2022

andrewkroh commented Nov 28, 2022

cmacknz left a comment

rdner commented Nov 28, 2022

Update test versions of NGINX, Apache and MongoDB #33789

Update test versions of NGINX, Apache and MongoDB #33789

Conversation

rdner commented Nov 23, 2022 • edited by cmacknz Loading

What does this PR do?

Why is it important?

Author's Checklist

elasticmachine commented Nov 23, 2022

elasticmachine commented Nov 23, 2022 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

rdner Nov 23, 2022

Choose a reason for hiding this comment

rdner Nov 24, 2022

Choose a reason for hiding this comment

andrewkroh commented Nov 28, 2022

andrewkroh commented Nov 28, 2022

rdner commented Nov 28, 2022

andrewkroh commented Nov 28, 2022

cmacknz left a comment

Choose a reason for hiding this comment

rdner commented Nov 28, 2022

rdner commented Nov 23, 2022 •

edited by cmacknz

Loading

elasticmachine commented Nov 23, 2022 •

edited by jenkins-beats-ci bot

Loading