Fix process monitoring FD leak #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you update CHANGELOG.md? |
…olang garbage collector automatically closes the FD associated with os.File which is why the FD count didn't grow completely unbounded; in my testing the FD count would cyclically grow to about ~500 and then drop back down to ~5. Close elastic#335
andrewkroh
force-pushed
the
bugfix/procs-fd-leak
branch
from
7f3614d
to
282ebf9
Compare
|
I updated the changelog for this PR. |
monicasarbu
added a commit
that referenced
this pull request
Oct 26, 2015
Fix process monitoring FD leak
|
@ruflin, is the plan to release this via GA or a -beta5? |
|
@portante The current plan is GA. |
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Jan 20, 2016
Fix process monitoring FD leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a file descriptor leak in the process monitoring feature. The golang garbage collector automatically closes the FD associated with os.File which is why the FD count didn't grow completely unbounded; in my testing the FD count would cyclically grow to about ~500 and then drop back down to ~5.
Close #335