Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqs consumers #33659

Closed
wants to merge 9 commits into from
Closed

sqs consumers #33659

wants to merge 9 commits into from

Conversation

aspacca
Copy link

@aspacca aspacca commented Nov 14, 2022

Enhancement

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@aspacca aspacca self-assigned this Nov 14, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @aspacca? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@aspacca aspacca added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Nov 14, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 14, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-29T02:22:16.238+0000

  • Duration: 131 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 5024
Skipped 340
Total 5364

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@aspacca aspacca requested a review from andrewkroh November 15, 2022 09:15
@aspacca aspacca marked this pull request as ready for review November 15, 2022 09:16
@aspacca aspacca requested a review from a team as a code owner November 15, 2022 09:16
@aspacca
Copy link
Author

aspacca commented Nov 15, 2022

@andrewkroh

For what I can see I think the real game change is your #33658

This PR could anyway help to scale out an sqs+s3 input on a single agent instance, giving the option to basically having a similar behaviour (specifically joint with your above PR) to set up different repeated single inputs for the same sqs queue

nit: I found the benchmark a little unclear, I've tried to make it more readable and effective (no matter how many msgs etc the constant receive was always returning 1 message)

I still have to add docs and default settings for number_of_sqs_consumers

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b sqs_consumers upstream/sqs_consumers
git merge upstream/main
git push upstream sqs_consumers

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b sqs_consumers upstream/sqs_consumers
git merge upstream/main
git push upstream sqs_consumers

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b sqs_consumers upstream/sqs_consumers
git merge upstream/main
git push upstream sqs_consumers

@jlind23
Copy link
Collaborator

jlind23 commented Nov 29, 2023

Closing this as it is for now outdated and hasn't been worked on for quite some time. Feel free to reopen it if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants