Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cap_net_raw requirements to heartbeat docs #32816

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add cap_net_raw requirements to heartbeat docs #32816

merged 1 commit into from
Sep 1, 2022

Conversation

emilioalvap
Copy link
Collaborator

What does this PR do?

Update HB public documentation to register capability requirements for Docker and K8s setups.

Why is it important?

We've had instances where this requirement was not met and it generated confusion.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

  • Build documentation locally following docs guide and check new content is available.

@emilioalvap emilioalvap added docs Team:obs-ds-hosted-services Label for the Observability Hosted Services team release-note:skip The PR should be ignored when processing the changelog v8.5.0 backport-v8.4.0 Automated backport with mergify labels Aug 24, 2022
@emilioalvap emilioalvap requested a review from andrewvc August 24, 2022 16:43
@emilioalvap emilioalvap requested review from a team as code owners August 24, 2022 16:43
@emilioalvap emilioalvap requested review from faec and leehinman and removed request for a team August 24, 2022 16:43
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 24, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 24, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-25T09:36:12.530+0000

  • Duration: 7 min 10 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@emilioalvap emilioalvap force-pushed the doc-hb-cap-requirements branch from 119e111 to fdd3cbd Compare August 25, 2022 09:35
@emilioalvap
Copy link
Collaborator Author

run elasticsearch-ci/docs

andrewvc
andrewvc approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilioalvap emilioalvap merged commit 2aeefb9 into elastic:main Sep 1, 2022
mergify bot pushed a commit that referenced this pull request Sep 1, 2022
@emilioalvap @mergify
Add cap_net_raw requirements to heartbeat docs (#32816)
2e46b2f 
(cherry picked from commit 2aeefb9)
@mergify mergify bot mentioned this pull request Sep 1, 2022
Merged
emilioalvap added a commit that referenced this pull request Sep 1, 2022
@mergify @emilioalvap
Add cap_net_raw requirements to heartbeat docs (#32816) (#32948)
614569f 
(cherry picked from commit 2aeefb9)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Sep 1, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/heartbeat-p…
a884d74 
…ackaging

* upstream/main: (109 commits)
  Add cap_net_raw requirements to heartbeat docs (elastic#32816)
  apply a quick hotfix for having main working properly (elastic#32934)
  action: checks for x-pack/libbeat and libbeat (elastic#32754)
  Update to Go 1.18 in go.mod. (elastic#32940)
  [heartbeat] disable browser code on windows via build tags (elastic#32939)
  action: checks for heartbeat and x-pack/heartbeat (elastic#32749)
  Make event acknowledgment asynchronous in shipper output (elastic#32785)
  [Automation] Update elastic stack version to 8.5.0-fedc3e60 for testing (elastic#32930)
  Preallocate memory to reduce GC load (elastic#32905)
  [Automation] Update elastic stack version to 8.5.0-440e0896 for testing (elastic#32919)
  Skip broken ceph tests. (elastic#32912)
  Use non-deprecated docker image for testing jolokia (elastic#32885)
  update ironbank image product name (elastic#32867)
  ci: pre-commit stage within Jenkins (elastic#32839)
  Fix a couple of bugs in the logic for how AWS metric periods are calculated (elastic#32724)
  [Filebeat] [httpjson] Add support for single string containing multiple relation-types in getRFC5988Link (elastic#32811)
  [Heartbeat] Update HB k8s template to use <Mi> metric (elastic#32801)
  action: checks for metricbeat and x-pack/metricbeat (elastic#32748)
  action: checks for filebeat and x-pack/filebeat (elastic#32746)
  allow for json/ndjson content type with charset (elastic#32767)
  ...
@emilioalvap emilioalvap added the backport-7.17 Automated backport to the 7.17 branch with mergify label Sep 19, 2022
@mergify mergify bot mentioned this pull request Sep 19, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 19, 2022
@emilioalvap @mergify
Add cap_net_raw requirements to heartbeat docs (#32816)
d2a64fd 
(cherry picked from commit 2aeefb9)
emilioalvap added a commit that referenced this pull request Sep 19, 2022
@mergify @emilioalvap
Add cap_net_raw requirements to heartbeat docs (#32816) (#33124)
31e009c 
(cherry picked from commit 2aeefb9)

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@emilioalvap @chrisberkhout
Add cap_net_raw requirements to heartbeat docs (#32816)
98fe462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@emilioalvap emilioalvap

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify docs release-note:skip The PR should be ignored when processing the changelog Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilioalvap @elasticmachine @andrewvc