winlogbeat: fix testing on windows 11 and re-enable #32519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Winlogbeat
Team:Security-External Integrations
backport-skip
botelastic
bot
added
needs_team
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
v1v
approved these changes
Jul 27, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
* fix invalid write * remove lint and provide errno for failure * squelch error when template not available * enable windows-11 testing (cherry picked from commit fe37716) # Conflicts: # winlogbeat/Jenkinsfile.yml # winlogbeat/sys/wineventlog/publisher_metadata.go # winlogbeat/sys/wineventlog/syscall_windows.go # x-pack/winlogbeat/Jenkinsfile.yml
efd6
added a commit
that referenced
this pull request
Sep 14, 2022
…enable (#33074) This change is derived from the changes listed but is only a partial backport. Tests for windows 11 have not been enabled, and linting fixes are not applied. Only buffer size error in the call to _EvtFormatMessage and short-circuiting EventMetadataIterator.Next when no handle is available are included in the patch. * winlogbeat: fix testing on windows 11 and re-enable (#32519) * fix invalid write * remove lint and provide errno for failure * squelch error when template not available * enable windows-11 testing (cherry picked from commit fe37716) # Conflicts: # winlogbeat/Jenkinsfile.yml # winlogbeat/sys/wineventlog/publisher_metadata.go # winlogbeat/sys/wineventlog/syscall_windows.go # x-pack/winlogbeat/Jenkinsfile.yml * fix conflicts and disable windows 11 testing * revert error handling changes * remove irrelevant changelog lines Co-authored-by: Dan Kortschak <[email protected]> Co-authored-by: Dan Kortschak <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* fix invalid write * remove lint and provide errno for failure * squelch error when template not available * enable windows-11 testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes two issues in winlogbeat that cause CI to fail on Windows 11.
Why is it important?
Previously the build was disabled on that version, reducing coverage.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs