-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand fields in decode_json_fields
if target is set
#32010
Merged
kvch
merged 7 commits into
elastic:main
from
kvch:fix-libbeat-expand-fields-without-target
Jun 21, 2022
Merged
Expand fields in decode_json_fields
if target is set
#32010
kvch
merged 7 commits into
elastic:main
from
kvch:fix-libbeat-expand-fields-without-target
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 21, 2022
Collaborator
kvch
requested review from
belimawr and
fearful-symmetry
and removed request for
a team
June 21, 2022 12:16
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 21, 2022
cmacknz
approved these changes
Jun 21, 2022
kvch
added
backport-v8.3.0
Automated backport with mergify
backport-7.17
Automated backport to the 7.17 branch with mergify
labels
Jun 21, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
## What does this PR do? This PR applies the settings in `expand_keys` to the event even if the target is not empty. ## Why is it important? Previously, if target was set to anything besides `""`, `expand_keys` did not work. So you could not expand the keys of the parsed JSON if you wanted to put it under a custom field. (cherry picked from commit 7b99a8e) # Conflicts: # libbeat/common/jsontransform/expand.go # libbeat/processors/actions/decode_json_fields.go # libbeat/processors/actions/decode_json_fields_test.go
mergify bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
## What does this PR do? This PR applies the settings in `expand_keys` to the event even if the target is not empty. ## Why is it important? Previously, if target was set to anything besides `""`, `expand_keys` did not work. So you could not expand the keys of the parsed JSON if you wanted to put it under a custom field. (cherry picked from commit 7b99a8e)
kvch
removed
the
backport-7.17
Automated backport to the 7.17 branch with mergify
label
Jun 21, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
## What does this PR do? This PR applies the settings in `expand_keys` to the event even if the target is not empty. ## Why is it important? Previously, if target was set to anything besides `""`, `expand_keys` did not work. So you could not expand the keys of the parsed JSON if you wanted to put it under a custom field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.3.0
Automated backport with mergify
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR applies the settings in
expand_keys
to the event even if the target is not empty.Why is it important?
Previously, if target was set to anything besides
""
,expand_keys
did not work. So you could not expand the keys of the parsed JSON if you wanted to put it under a custom field.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Config:
Example input file:
Check if the keys are expanded in the published event:
Related issues
Closes #31712