Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS SDK v2] Upgrade library common credentials #31225

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Apr 7, 2022

Adding here only the libbeat/common/aws package

Wanderer, if you pass by here, you have more info in #31224

It will be cool if a couple of us can test this manually, at least to ensure that I haven't missed anything.

@sayden sayden requested a review from kaiyan-sheng April 7, 2022 19:47
@sayden sayden self-assigned this Apr 7, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2022
@botelastic
Copy link

botelastic bot commented Apr 7, 2022

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-07T19:48:16.998+0000

  • Duration: 14 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

Steps errors 12

Expand to view the steps failures

Show only the first 10 steps failures

x-pack/filebeat-lint - make -C x-pack/filebeat check;make -C x-pack/filebeat update;make -C filebe
  • Took 1 min 46 sec . View more details here
  • Description: make -C x-pack/filebeat check;make -C x-pack/filebeat update;make -C filebeat check;make -C filebeat update;make check-no-changes;
x-pack/functionbeat-lint - make -C x-pack/functionbeat check;make -C x-pack/functionbeat update;ma
  • Took 1 min 38 sec . View more details here
  • Description: make -C x-pack/functionbeat check;make -C x-pack/functionbeat update;make check-no-changes;
x-pack/heartbeat-lint - make -C x-pack/heartbeat check;make -C x-pack/heartbeat update;make -C hea
  • Took 1 min 44 sec . View more details here
  • Description: make -C x-pack/heartbeat check;make -C x-pack/heartbeat update;make -C heartbeat check;make -C heartbeat update;make check-no-changes;
x-pack/libbeat-lint - make -C x-pack/libbeat check;make -C x-pack/libbeat update;make check-no-cha
  • Took 1 min 43 sec . View more details here
  • Description: make -C x-pack/libbeat check;make -C x-pack/libbeat update;make check-no-changes;
x-pack/metricbeat-lint - make -C x-pack/metricbeat check;make -C x-pack/metricbeat update;make -C
  • Took 1 min 44 sec . View more details here
  • Description: make -C x-pack/metricbeat check;make -C x-pack/metricbeat update;make -C metricbeat check;make -C metricbeat update;make check-no-changes;
x-pack/osquerybeat-lint - make -C x-pack/osquerybeat check;make -C x-pack/osquerybeat update;make
  • Took 0 min 7 sec . View more details here
  • Description: make -C x-pack/osquerybeat check;make -C x-pack/osquerybeat update;make check-no-changes;
x-pack/packetbeat-lint - make -C packetbeat check;make -C packetbeat update;make check-no-changes;
  • Took 1 min 48 sec . View more details here
  • Description: make -C packetbeat check;make -C packetbeat update;make check-no-changes;
x-pack/winlogbeat-lint-immutable && ubuntu-18 - make -C x-pack/winlogbeat check;make -C x-pack/winl
  • Took 1 min 45 sec . View more details here
  • Description: make -C x-pack/winlogbeat check;make -C x-pack/winlogbeat update;make -C winlogbeat check;make -C winlogbeat update;make check-no-changes;
make check-default
  • Took 1 min 18 sec . View more details here
  • Description: make check-default
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@sayden sayden marked this pull request as ready for review April 13, 2022 07:07
@sayden sayden requested a review from a team as a code owner April 13, 2022 07:07
Copy link

@aspacca aspacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sayden , beware that the code you are changing got a bugfix from https://github.com/elastic/beats/pull/31014/files that doesn't seem to be included in the feature branch :)

@cmacknz cmacknz removed request for a team and kaiyan-sheng April 13, 2022 18:55
@sayden
Copy link
Contributor Author

sayden commented Apr 14, 2022

hi @sayden , beware that the code you are changing got a bugfix from https://github.com/elastic/beats/pull/31014/files that doesn't seem to be included in the feature branch :)

oh my god, this is exactly what scares the s*** out of me. Thanks for the heads up!

@sayden
Copy link
Contributor Author

sayden commented Apr 20, 2022

After a short conversation with Beats team, we'll create a big fat PR. Closing this

@sayden sayden closed this Apr 20, 2022
@sayden sayden deleted the feature/xpack/aws/upgrade-library-common-credentials branch August 25, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants