-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cronjob metadata by default #30637
Conversation
Signed-off-by: chrismark <[email protected]>
This pull request doesn't have a |
Signed-off-by: chrismark <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
for versions of k8s >= v1.21. | ||
This metricset adds metadata by default only for versions of k8s >= v1.21. | ||
For older versions the APIs are not compatible and one need to configure the | ||
metricset with `add_metadata: false` and remove the proper `apiGroup` in the `ClusterRole`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should be a bit more specific here of what they need to remove. Why not add an example with the specific part of the cluster role they need to remove?
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Trying to isolate the CI failures at #30685. Something is really weird here. |
Waiting for #30732 to see if an upgrade fixes things. |
Signed-off-by: chrismark <[email protected]>
Something is odd with the way we test on the CI as described at #30733. For now we can disable metadata addition for state_cronjob tests. I will file a separate issue for this so as to keep it tracked. For reference, the metricset is indirectly tested about this functionality under integrations repo so we can claim that it is safe to skip metadata here for now. @MichaelKatsoulis let me know what you think about this. |
Signed-off-by: chrismark <[email protected]>
Although it is a dirty workaround, it does not seem to be another way. So +1 |
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
What does this PR do?
cronjob.name
for Pods handled by aJob
but are actually created because of a CronJob: https://github.com/elastic/beats/pull/30637/files#diff-e127eb943d1a3edae0a9f12cc7c3849874a256ae557242bf1473a1a28654fe64R101Why is it important?
In order to make metadata addition for cronjob objects by default.
Related issues
cc: @MichaelKatsoulis