Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Add message to register encode/decode debug logs #30271

Merged
merged 2 commits into from
Feb 14, 2022
Merged

[Filebeat] Add message to register encode/decode debug logs #30271

merged 2 commits into from
Feb 14, 2022

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Add message to the debug log indicating which encoder/decoder is being registered instead of only logging the error (nil or not) returned.

Why is it important?

A log message <nil> is unclear.

Checklist

  • [x ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

Current behaviour

Jan 26, 2022 @ 07:03:24.636 | debug | <nil> | filebeat

After changes:

Jan 26, 2022 @ 07:03:24.636 | debug | registering encoder 'application/json': returned error: <nil> | filebeat

@AndersonQ AndersonQ added enhancement v8.0.0 backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify labels Feb 8, 2022
@AndersonQ AndersonQ requested a review from belimawr February 8, 2022 11:59
@AndersonQ AndersonQ self-assigned this Feb 8, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2022
@AndersonQ AndersonQ added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 8, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 8, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-11T07:17:42.247+0000

  • Duration: 104 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 9642
Skipped 1285
Total 10927

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlind23
Copy link
Collaborator

jlind23 commented Feb 8, 2022

@AndersonQ even if it's about improving readability it shouldn't be backported to 8.0 but rather stay in 8.2

@AndersonQ
Copy link
Member Author

/package

@AndersonQ AndersonQ added v8.2.0 and removed backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify v8.0.0 labels Feb 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 8, 2022

This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 8, 2022
@AndersonQ
Copy link
Member Author

/test

belimawr
belimawr approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I believe %#v is a bit too much, what about %v?

@kvch
Copy link
Contributor

kvch commented Feb 10, 2022

jenkins run tests

@kvch
Copy link
Contributor

kvch commented Feb 10, 2022

I think it is ready to be merged.

@AndersonQ AndersonQ merged commit 3de59f0 into main Feb 14, 2022
v1v added a commit to v1v/beats that referenced this pull request Feb 21, 2022
@v1v
Merge branch 'feature/use-with-kind-k8s-env' of github.com:v1v/beats …
c20f180 
…into feature/use-with-kind-k8s-env

* 'feature/use-with-kind-k8s-env' of github.com:v1v/beats: (52 commits)
  ci: home is declared within withBeatsEnv
  ci: use withKindEnv step
  ci: use getBranchesFromAliases and support next-patch-8 (elastic#30400)
  Update fields.yml (elastic#29609)
  Heartbeat: fix browser metrics and trace mappings (elastic#30258)
  Apply light edits to 8.0 changelog (elastic#30351)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed (elastic#30396)
  Add a ring-buffer reporter to libbeat (elastic#28750)
  Osquerybeat: Add install verification for osquerybeat (elastic#30388)
  update windows matrix support (elastic#30373)
  Refactor of metricbeat process-gathering metrics and system/process (elastic#30076)
  adjust next changelog wording (elastic#30371)
  [Metricbeat] azure: move event report into loop validDim loop (elastic#29945)
  fix: report GitHub Check before the cache (elastic#30372)
  Add support for non-unique keys in Kafka output headers (elastic#30369)
  ci: 6 major branch reached EOL (elastic#30357)
  reduce Elastic Agent shut down time by stopping processes concurrently (elastic#29650)
  [Filebeat] Add message to register encode/decode debug logs (elastic#30271)
  [libbeat] kafka message header support (elastic#29940)
  Heartbeat: set duration to zero for syntax errors (elastic#30227)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@belimawr belimawr belimawr approved these changes

Assignees

@AndersonQ AndersonQ

Labels
backport-skip Skip notification from the automated backport with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndersonQ @elasticmachine @jlind23 @kvch @belimawr @cmacknz