-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Keep debug symbols, no inline and no optimisations for dev builds #29961
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
@AndersonQ is this one good to be reviewed? |
/test metricbeat-windows-2016-windows-2016 |
@jlind23 yes, it's ready for review. The failing tests seem to be unrelated to my changes. But I'm looking at them now |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, I've looked at the test suite and this looks like an issue with the python environment on windows. Two possible reasons:
- The Windows images changed ? @v1v
- We are missing the
venv
python module in our requirements https://docs.python.org/3/library/venv.html
Maybe both are true?
The runtime configuration script to prepare the context failed but it didn't exit 1, therefore it ran the mage build/test
The behaviour then fallbacks to the current installed software in the Worker, and it seems python2 is the default one. For the moment, just type |
/test |
What does this PR do?
When the agent is built for development it keeps the debug symbols, do not inline nor optimize so it's possible to debug using delve.
It also fixes a typo.
Why is it important?
Improves developer experience by making it ready for debug when building for development.
Checklist
[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Build with
DEV=true
, then run it with delve and connect to remote debugUsing GoLand, you can run the elastic-agent as below and use the Go Remote to Run/Debug the agent.
Related issues