Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] gcp: update sample datas #29637

Closed
wants to merge 1 commit into from

Conversation

endorama
Copy link
Member

What does this PR do?

This PR updates gcp module sample events.

Why is it important?

Sample events have not been updated as part of #27974. Integrations tests are broken due to this mismatch, as has been discovered working on elastic/integrations#2301

There are some notes to this:

  1. we don't run GCP integrations tests in the CI, so we were not able to catch these
  2. the method for updating this sample data (go test -data) is not well documented

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 29, 2021
@endorama endorama marked this pull request as draft December 29, 2021 17:40
@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 29, 2021
@endorama
Copy link
Member Author

I'm facing some issues in updating the data: for compute module, the update code is not able to fetch events. For billing module it seems the -data flag is not available, so it cannot be run. Debug in progress

@endorama endorama self-assigned this Dec 29, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T10:14:48.081+0000

  • Duration: 94 min 23 sec

  • Commit: fe18e23

Test stats 🧪

Test Results
Failed 0
Passed 2763
Skipped 240
Total 3003

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jan 24, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2022
@jlind23
Copy link
Collaborator

jlind23 commented Apr 1, 2022

@endorama closing for now until further updates.

@jlind23 jlind23 closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants