Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to username/password #29458

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Dec 15, 2021

What does this PR do?

Remove the use of username/password for authenication

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Create an 8.1 cluster and use a snapshot of the fleet-server from elastic/fleet-server#1006

Related issues

@michel-laterman michel-laterman added cleanup backport-v8.0.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Dec 15, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 15, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-22T20:38:29.844+0000

  • Duration: 99 min 29 sec

  • Commit: 47181e3

Test stats 🧪

Test Results
Failed 0
Passed 7120
Skipped 16
Total 7136

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23 jlind23 requested a review from a team December 23, 2021 10:07
@michel-laterman michel-laterman merged commit bea8e45 into elastic:master Dec 23, 2021
@michel-laterman michel-laterman deleted the agent-remove-password branch December 23, 2021 17:22
mergify bot pushed a commit that referenced this pull request Dec 23, 2021
* Remove references to username/password

* restore ouput username/password

* Update CHANGELOG

(cherry picked from commit bea8e45)
michel-laterman added a commit that referenced this pull request Dec 23, 2021
* Remove references to username/password

* restore ouput username/password

* Update CHANGELOG

(cherry picked from commit bea8e45)

Co-authored-by: Michel Laterman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.0.0 Automated backport with mergify cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants