-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/module/sophos/xg: fix kv field separation and add support for timestamped log line #29331
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
First commit is the interesting one, second is entirely mechanical. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…port for timestamped log line (#29331) (#29672) This change also needed changes in the cisco asa module's test expect files to bring timestamp handling during testing up to date. (cherry picked from commit 0ea9581) Co-authored-by: Dan Kortschak <[email protected]>
What does this PR do?
This fixes KV field separation and adds support for log lines that have syslog-style timestamps and hostname headers.
Why is it important?
The current situation is breaking some users.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Python integration tests for x-pack filebeat,
Related issues
Use cases
N/A
Screenshots
N/A
Logs
N/A