-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s autodiscover metadata in nodes earlier #29289
Conversation
Nodes metadata is used by autodiscover to include it in events or to generate autodiscover hints for the pods in the node. This change watches explicitly for changes in nodes to update this metadata instead of waiting for resyncs. Signed-off-by: chrismark <[email protected]>
Pinging @elastic/integrations (Team:Integrations) |
This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
NOTE: |
Signed-off-by: chrismark <[email protected]>
/package |
This pull request is now in conflicts. Could you fix it? 🙏
|
Signed-off-by: chrismark <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
/package |
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
2bc6a3d
to
2798e05
Compare
Signed-off-by: chrismark <[email protected]>
/package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
/package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/package |
What does this PR do?
Node metadata is used by autodiscover to include it in events or
to generate autodiscover hints for the pods in the node.
This change watches explicitly for changes in nodes to update these
metadata immediately instead of waiting for full resyncs.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues