Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apm-server: Remove data_streams.enabled flag #29168

Conversation

marclop
Copy link
Contributor

@marclop marclop commented Nov 29, 2021

What does this PR do?

Removes the "apm-server.data_streams.enabled flag in the apm-server
spec, since it's been marked as deprecated in 8.0.

Why is it important?

To avoid apm-server logging deprecation messages.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation

  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

elastic/apm-server#6606

Removes the `"apm-server.data_streams.enabled` flag in the `apm-server`
spec, since it's been marked as deprecated in `8.0`.

Signed-off-by: Marc Lopez Rubio <[email protected]>
@marclop marclop added v8.0.0 cleanup backport-v8.0.0 Automated backport with mergify labels Nov 29, 2021
@marclop marclop requested a review from a team November 29, 2021 03:09
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2021
@marclop marclop added the Team:apm APM Server team issues/PRs label Nov 29, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-28T06:07:54.022+0000

  • Duration: 97 min 59 sec

  • Commit: e1d9d2f

Test stats 🧪

Test Results
Failed 0
Passed 7120
Skipped 16
Total 7136

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Signed-off-by: Marc Lopez Rubio <[email protected]>
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@marclop
Copy link
Contributor Author

marclop commented Dec 28, 2021

/test

@stuartnelson3 stuartnelson3 merged commit 6794652 into elastic:master Dec 28, 2021
mergify bot pushed a commit that referenced this pull request Dec 28, 2021
* apm-server: Remove `data_streams.enabled` flag

Removes the `"apm-server.data_streams.enabled` flag in the `apm-server`
spec, since it's been marked as deprecated in `8.0`.

Signed-off-by: Marc Lopez Rubio <[email protected]>
(cherry picked from commit 6794652)
marclop pushed a commit that referenced this pull request Dec 29, 2021
Removes the `"apm-server.data_streams.enabled` flag in the `apm-server`
spec, since it's been marked as deprecated in `8.0`.

Signed-off-by: Marc Lopez Rubio <[email protected]>
(cherry picked from commit 6794652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.0.0 Automated backport with mergify cleanup Team:apm APM Server team issues/PRs v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants