Add explicit username and password option for Mongodb #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
in progress
ruflin
reviewed
Oct 31, 2016
| #hosts: ["localhost:27017"] | ||
|
|
||
| # Username to use when connecting to MongoDB. Empty by default. | ||
| # username: user |
There was a problem hiding this comment.
no space in front of username and password needed
| if err != nil { | ||
| return nil, err | ||
| } | ||
| info.Timeout = base.Module().Config().Timeout |
|
Not strictly a bug fix, but I think we should backport this to the 5.0 branch as it makes it really difficult to use the MongoDB module otherwise. |
We previously only had the option of specifying a user/pass in the URL string, which is problematic because it results in the password being indexed in Elasticsearch (elastic#2888). This adds the option to specify a username/password at the module configuration. To make this happen, I had to copy some unexported functions from the mgo driver.
tsg
force-pushed
the
mongodb_user_pass_options
branch
from
c3953b0
to
c03da67
Compare
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Nov 1, 2016
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL.
ruflin
pushed a commit
that referenced
this pull request
Nov 1, 2016
Similar to #2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL.
tsg
added a commit
to tsg/beats
that referenced
this pull request
Nov 1, 2016
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL. (cherry picked from commit f0b52e1)
tsg
added a commit
to tsg/beats
that referenced
this pull request
Nov 1, 2016
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL. (cherry picked from commit f0b52e1)
This was referenced Nov 1, 2016
monicasarbu
pushed a commit
that referenced
this pull request
Nov 1, 2016
tsg
added a commit
to tsg/beats
that referenced
this pull request
Nov 1, 2016
We previously only had the option of specifying a user/pass in the URL string, which is problematic because it results in the password being indexed in Elasticsearch (elastic#2888). This adds the option to specify a username/password at the module configuration. To make this happen, I had to copy some unexported functions from the mgo driver. (cherry picked from commit 6c7dfe4)
andrewkroh
pushed a commit
that referenced
this pull request
Nov 1, 2016
We previously only had the option of specifying a user/pass in the URL string, which is problematic because it results in the password being indexed in Elasticsearch (#2888). This adds the option to specify a username/password at the module configuration. To make this happen, I had to copy some unexported functions from the mgo driver. (cherry picked from commit 6c7dfe4)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Similar to elastic#2889 but for PostgreSQL. Also adds docs to the Postgres module, which were missing, and adjusted the integration tests to use the username option instead of the full URL. (cherry picked from commit f1fb61d)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#2900) We previously only had the option of specifying a user/pass in the URL string, which is problematic because it results in the password being indexed in Elasticsearch (elastic#2888). This adds the option to specify a username/password at the module configuration. To make this happen, I had to copy some unexported functions from the mgo driver. (cherry picked from commit b4f22e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only had the option of specifying a user/pass in the
URL string, which is problematic because it results in the password
being indexed in Elasticsearch (#2888).
This adds the option to specify a username/password at the module
configuration. To make this happen, I had to copy some unexported
functions from the mgo driver.